Architecture/planning/evolution-data-server/QtContacts storage plugin

Revision as of 13:41, 3 June 2011

QtContacts-EDS

The code is based on existing Maemo 5 EDS plugin, which did not work as-is because of Nokia-specific API extensions.

Necessary changes:

• avoid ID mapping because it requires reading all contacts at startup:
  • must change EDS to use 32 bit integers as local IDs for that (patch ready)
  • alternatively, collision-safe ID hashing support in QtContacts-EDS by defining USE_ID_HASHING at compilation time
• convert between QtContacts and vCard using QtVersit, with EDS specific properties and including custom properties for QtContactDetails which have no other mapping to vCard (same approach as in SyncEvolution QtContacts backend)
• EDS needs to be patched to support server-side filtering of dates GNOME #651113, photo uris GNOME #651054 and non-unique attributes GNOME #650950.
• EDS needs to be patched to support optional / delayed parsing of vCards when emitting signals in EBookView GNOME #651446 and GNOME #651541.

Goals for initial milestone:

• full support for all QContactDetails, including custom ones and additional fields of details which map to well-known vCard properties (QContactUrl::SubTypeFavourite, QContactAvatar::videoUrl, QContactOrganization::FieldLocation...)
  • The following fields are not saved: QContactAnniversary::FieldEvent, QContactAnniversary::FieldCalendarId
  • QContactGeoLocation detail is not interoperable with libebook/EDS because QtVersit reverses latitude/longitude in the vCard QTMOBILITY-1589
  • QContactOnlineAccount is not interoperable with libebook/EDS (not direct equivalent is available in vCard)
  • There does not seem to be any equivalent for X-EVOLUTION-MANAGER in QtContacts, no mapping is done for this extension
  • QContactOrganization::FieldDepartment is not fully interoperable with libebook/EDS (libebook can only parse one department)
  • QContactOrganization does not have any API for binary (QImage) organization logo (Only URL: QContactOrganization::FieldLocation) but libebook supports both
  • The following details are not interoperable with libebook/EDS (but they can be saved): QContactGender, QContactFamily::FieldChildren (X-CHILDREN), QContactGlobalPresence, QContactFavorite, QContactHobby, QContactPresence, QContactRingtone, QContactSyncTarget.
• change notifications (added/updated/removed)
  • There does not seem to be any signal in ebook view for selfContactIdChange?
• mapping of QtContacts filters to EDS queries, with unsupported filters implemented by QtContacts after retrieving contacts (slower than filtering in EDS daemon)
  • Non-native search used for QContactFavorite::FieldIndex, QContactGeoLocation, QContactGlobalPresence, QContactOnlineAccount, QContactPresence, QContactRingtone.
  • Partially native search is used when CaseSentive match flag is set because EDS does not support case sensitive matching
• Errors are properly handled and reported to the client application

Goals for later milestones:

• performance improvement

Testing:

• Packages for patched evolution-data-server and qtcontacts-eds backend are maintained in devel:meego-ux repository.

Related bugs:

• QTMOBILITY-1298 QtVersit does not allow custom properties to have complex types
• QTMOBILITY-1592 QContactManagerEngine schema definitions are incomplete
• QTMOBILITY-1590 QtVersit contact importer does not follow RFC-2426 for LOGO/PHOTO value (MERGED UPSTREAM for v1.2.1)
• QTMOBILITY-1589 QtVersit writes/reads QContactGeoLocation's latitude/longitude in reverse order (Compared to RFC-2426 and libebook)
• QTMOBILITY-1623 QContactManagerEngine::CompareVariant() does not support QVariant::StringList
• QTMOBILITY-1667 QContactManagerEngine::CompareVariant() does not support QVariant::Url
• GNOME #650952 EDS displays misleading warnings such as "libebook-WARNING **: unknown field name `X-GENDER'" (MERGED UPSTREAM, master only)
• GNOME #650950 EDS: Queries should iterate over all attributes with the same name for proper matching (MERGED UPSTREAM, master only)
• GNOME #651054 EDS: Support queries based on "photo" contact field. This is needed for EDS-side QContactAvatar::FieldImageUrl filtering. (MERGED UPSTREAM, master only)
• GNOME #651113 EDS: Support queries based on date field (e.g. birthday, anniversary). (MERGED UPSTREAM, master only)
• GNOME #651226 EDS: e_book_new_system_addressbook() should create source in GConf (REVIEWED by dwmw2)
• GNOME #651433 EDS: Possible memory leak in e_book_backend_file_get_contact_list() (ACCEPTED UPSTREAM)
• GNOME #651435 EDS: Possible memory leak in e_name_western_reorder_asshole() (ACCEPTED UPSTREAM)
• GNOME #651436 EDS: Possible memory leak in e_contact_name_from_string() (ACCEPTED UPSTREAM)
• GNOME #651459 EDS: Possible memory leak in e_book_backend_file_changes_foreach_key() (ACCEPTED UPSTREAM)
• GNOME #651461 EDS: Possible memory leak in e_book_backend_file_get_changes() (ACCEPTED UPSTREAM)
• GNOME #651466 EDS: e_dbhash_new: Close and reopen db handle to avoid memory leak
• GNOME #651468 EDS: Possible memory leak in return_error_and_list()
• GNOME #651446 EDS: EBookView: Implement optional / delayed vCard parsing (REJECTED by UPSTREAM)
• GNOME #651541 EDS: EBook: Implement optional / delayed vCard parsing (REJECTED by UPSTREAM)

Contacts:

• Patrick Ohly
• Christophe Dumez